Ship Tekton Hub via Tekton Operator by vinamra28 · Pull Request #467 · tektoncd/operator

vinamra28 · 2021-10-26T05:02:04Z

Changes

This following patch contains controllers for deploying Tekton Hub DB
and API components. This also contains a post-reconciler based on
platform which will add an Ingress in case of kubernetes and Route in
case of OpenShift.

Signed-off-by: vinamra28 vinjain@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Add Tekton Hub DB and API reconcilers to ship via Tekton Operator.

tekton-robot · 2021-10-26T05:05:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.5%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

sm43 · 2021-10-26T05:08:35Z

pkg/apis/operator/v1alpha1/tektonhub_defaults.go

+func (th *TektonHub) SetDefaults(ctx context.Context) {
+
+	if th.Spec.Db.DbSecretName == "" {
+		th.Spec.Db.DbSecretName = "db"


in what namespace the secret need to be created? / will be created?

we should prefix tekton-hub- to all hub resources

+1 on having prefix, we need to refactor the yamls a bit so that they are specific to tekton hub

pkg/reconciler/common/releases.go

sm43 · 2021-10-26T05:12:37Z

Could you also add a doc with installations steps.. would be easy to review :)

tekton-robot · 2021-10-26T05:39:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.5%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

tekton-robot · 2021-10-26T05:49:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.5%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

tekton-robot · 2021-10-27T05:32:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.5%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

docs/TektonHub.md

pkg/apis/operator/v1alpha1/tektonhub_types.go

tekton-robot · 2021-10-27T06:20:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.5%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

tekton-robot · 2021-10-28T09:16:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.5%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

tekton-robot · 2021-10-28T09:21:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.5%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go

pkg/apis/operator/v1alpha1/tektonhub_lifecycle_test.go

pkg/reconciler/kubernetes/tektonhub/tektonhub.go

tekton-robot · 2022-02-25T09:26:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	95.5%	-4.5
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-25T11:33:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-25T12:07:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-25T12:08:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-25T12:14:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-25T12:25:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-25T23:17:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-28T04:55:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-28T04:56:04Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-28T05:01:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

PuneetPunamiya · 2022-02-28T07:17:02Z

/test pull-tekton-operator-integration-tests

tekton-robot · 2022-02-28T08:48:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

piyush-garg · 2022-03-01T10:05:09Z

/hold cancel

nikhil-thomas · 2022-03-01T10:44:00Z

/hold cancel

holding till we have a mechanism to pull in hub payload (instead of adding the release.yaml in this codebase)

as this is resolved.
the release.yaml is not embedded in the codebase anymore.

This following patch contains controllers for deploying Tekton Hub DB and API components. This also contains a post-reconciler based on platform which will add an Ingress in case of kubernetes and Route in case of OpenShift. Signed-off-by: vinamra28 <vinjain@redhat.com>

tekton-robot · 2022-03-02T10:06:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.1%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

nikhil-thomas · 2022-03-02T10:45:07Z

/lgtm

nikhil-thomas · 2022-03-02T10:45:20Z

/approve

tekton-robot · 2022-03-02T10:45:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nikhil-thomas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 26, 2021

tekton-robot requested review from piyush-garg and pradeepitm12 October 26, 2021 05:02

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 26, 2021

sm43 reviewed Oct 26, 2021

View reviewed changes

pkg/reconciler/common/releases.go Outdated Show resolved Hide resolved

vinamra28 force-pushed the tekton-hub-in-operator branch from 0259532 to 2e68b39 Compare October 26, 2021 05:36

vinamra28 force-pushed the tekton-hub-in-operator branch from 2e68b39 to 8cbdaa3 Compare October 26, 2021 05:46

vinamra28 force-pushed the tekton-hub-in-operator branch from 8cbdaa3 to 1628274 Compare October 27, 2021 05:28

PuneetPunamiya reviewed Oct 27, 2021

View reviewed changes

docs/TektonHub.md Outdated Show resolved Hide resolved

PuneetPunamiya reviewed Oct 27, 2021

View reviewed changes

docs/TektonHub.md Outdated Show resolved Hide resolved

PuneetPunamiya reviewed Oct 27, 2021

View reviewed changes

pkg/apis/operator/v1alpha1/tektonhub_types.go Outdated Show resolved Hide resolved

PuneetPunamiya reviewed Oct 27, 2021

View reviewed changes

pkg/apis/operator/v1alpha1/tektonhub_types.go Outdated Show resolved Hide resolved

vinamra28 force-pushed the tekton-hub-in-operator branch from 1628274 to cb64ff6 Compare October 27, 2021 06:16

vinamra28 force-pushed the tekton-hub-in-operator branch from cb64ff6 to 547d336 Compare October 28, 2021 09:12

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2021

vinamra28 force-pushed the tekton-hub-in-operator branch from 547d336 to 4faeea9 Compare October 28, 2021 09:17

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2021

PuneetPunamiya reviewed Oct 28, 2021

View reviewed changes

pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go Show resolved Hide resolved

PuneetPunamiya reviewed Oct 28, 2021

View reviewed changes

pkg/apis/operator/v1alpha1/tektonhub_lifecycle_test.go Outdated Show resolved Hide resolved

PuneetPunamiya reviewed Oct 28, 2021

View reviewed changes

pkg/reconciler/kubernetes/tektonhub/tektonhub.go Show resolved Hide resolved

vinamra28 force-pushed the tekton-hub-in-operator branch from 497438a to 3024723 Compare February 25, 2022 12:06

vinamra28 force-pushed the tekton-hub-in-operator branch from 0cde000 to 9b6ae91 Compare February 28, 2022 04:53

vinamra28 force-pushed the tekton-hub-in-operator branch from 9b6ae91 to 5d0d041 Compare February 28, 2022 04:58

vinamra28 force-pushed the tekton-hub-in-operator branch from 5d0d041 to e794aeb Compare February 28, 2022 08:45

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022

vinamra28 force-pushed the tekton-hub-in-operator branch from e794aeb to e542f81 Compare March 2, 2022 10:04

tekton-robot assigned nikhil-thomas Mar 2, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022

tekton-robot merged commit 01d6f3e into tektoncd:main Mar 2, 2022

vinamra28 deleted the tekton-hub-in-operator branch October 6, 2023 18:28

Conversation

vinamra28 commented Oct 26, 2021

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Oct 26, 2021

Uh oh!

sm43 Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

sm43 Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

piyush-garg Nov 23, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sm43 commented Oct 26, 2021

Uh oh!

tekton-robot commented Oct 26, 2021

Uh oh!

tekton-robot commented Oct 26, 2021

Uh oh!

tekton-robot commented Oct 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Oct 27, 2021

Uh oh!

tekton-robot commented Oct 28, 2021

Uh oh!

tekton-robot commented Oct 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Feb 25, 2022

Uh oh!

tekton-robot commented Feb 25, 2022

Uh oh!

tekton-robot commented Feb 25, 2022

Uh oh!

tekton-robot commented Feb 25, 2022

Uh oh!

tekton-robot commented Feb 25, 2022

Uh oh!

tekton-robot commented Feb 25, 2022

Uh oh!

tekton-robot commented Feb 25, 2022

Uh oh!

tekton-robot commented Feb 28, 2022

Uh oh!

tekton-robot commented Feb 28, 2022

Uh oh!

tekton-robot commented Feb 28, 2022

Uh oh!

PuneetPunamiya commented Feb 28, 2022

Uh oh!

tekton-robot commented Feb 28, 2022

Uh oh!

piyush-garg commented Mar 1, 2022

Uh oh!

nikhil-thomas commented Mar 1, 2022

Uh oh!

tekton-robot commented Mar 2, 2022

Uh oh!

nikhil-thomas commented Mar 2, 2022

Uh oh!

nikhil-thomas commented Mar 2, 2022

Uh oh!

tekton-robot commented Mar 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone