Adds scope-when-expressions-to-task field for Pipelines#390
Merged
tekton-robot merged 2 commits intotektoncd:mainfrom Aug 27, 2021
Merged
Adds scope-when-expressions-to-task field for Pipelines#390tekton-robot merged 2 commits intotektoncd:mainfrom
scope-when-expressions-to-task field for Pipelines#390tekton-robot merged 2 commits intotektoncd:mainfrom
Conversation
This adds a new field in TektonPipeline to alter value for new field in `feature-flag` configmap. field: scope-when-expressions-to-task (Default: false) Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
vdemeester
approved these changes
Aug 24, 2021
Member
vdemeester
left a comment
There was a problem hiding this comment.
@sm43 any other field that are in tektoncd/pipeline and not here ?
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
@vdemeester nop. all are there, this was recently added in 0.27 due to which was missing from Operator. |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new field in TektonPipeline to alter value for new field
in
feature-flagconfigmap.field: scope-when-expressions-to-task (Default: false)
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes