Skip to content

Adds scope-when-expressions-to-task field for Pipelines#390

Merged
tekton-robot merged 2 commits intotektoncd:mainfrom
sm43:new-feature-flag
Aug 27, 2021
Merged

Adds scope-when-expressions-to-task field for Pipelines#390
tekton-robot merged 2 commits intotektoncd:mainfrom
sm43:new-feature-flag

Conversation

@sm43
Copy link
Member

@sm43 sm43 commented Aug 24, 2021

This adds a new field in TektonPipeline to alter value for new field
in feature-flag configmap.
field: scope-when-expressions-to-task (Default: false)

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 24, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2021
This adds a new field in TektonPipeline to alter value for new field
in `feature-flag` configmap.
field: scope-when-expressions-to-task (Default: false)

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the new-feature-flag branch from e521066 to e4de37c Compare August 24, 2021 07:56
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm43 any other field that are in tektoncd/pipeline and not here ?

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@sm43
Copy link
Member Author

sm43 commented Aug 24, 2021

@sm43 any other field that are in tektoncd/pipeline and not here ?

@vdemeester nop. all are there, this was recently added in 0.27 due to which was missing from Operator.

@nikhil-thomas
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2021
@tekton-robot tekton-robot merged commit f66f13e into tektoncd:main Aug 27, 2021
@sm43 sm43 deleted the new-feature-flag branch October 10, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants