config: replace any wildcard verbs by a list#384
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Aug 19, 2021
Merged
Conversation
tekton-robot
added
release-note
Member
|
/approve |
tekton-robot
added
the
approved
Member
Author
hum.. actual legit failure I think 😓 which is super weird.. except if I missed some verb.. |
Member
Author
|
/retest |
vdemeester
force-pushed
the
no-wildcard-verbs
branch
from
954e724 to
3d3d425
Compare
tekton-robot
added
size/L
vdemeester
force-pushed
the
no-wildcard-verbs
branch
from
3d3d425 to
da4f995
Compare
Member
Author
|
/retest |
Member
|
is it because of |
Member
|
/retest |
Member
Author
|
Still a legit failure.. damn… |
vdemeester
force-pushed
the
no-wildcard-verbs
branch
4 times, most recently
from
1553e91 to
fa00c6c
Compare
Better be explicit on the verbs we allow than the wildcard (`*`). Next step would be to see if we need all these or not. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
no-wildcard-verbs
branch
from
fa00c6c to
8fb5d81
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas, pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Better be explicit on the verbs we allow than the wildcard (
*). Nextstep would be to see if we need all these or not.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/cc @tektoncd/operator-collaborators @tektoncd/operator-maintainers
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes