fix: propagate TektonConfig config to TektonResult CR#3250
Open
pratap0007 wants to merge 1 commit intotektoncd:mainfrom
Open
fix: propagate TektonConfig config to TektonResult CR#3250pratap0007 wants to merge 1 commit intotektoncd:mainfrom
pratap0007 wants to merge 1 commit intotektoncd:mainfrom
Conversation
copy the spec.config (nodeSelector, tolerations, priorityClassName) from TektonConfig into the TektonResult CR in GetTektonResultCR and keep it in sync in UpdateResult, so Results pods are scheduled according to TektonConfig config's configuration Signed-off-by: Shiv Verma <shverma@redhat.com>
tekton-robot
added
the
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
size/M
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the spec.config (nodeSelector, tolerations, priorityClassName) from TektonConfig into the TektonResult CR in GetTektonResultCR and keep it in sync in UpdateResult, so Results pods are scheduled according to TektonConfig config's configuration
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes