Promise.any & AggregateError tests (supercedes and closes gh-2437) #2533

rwaldron · 2020-03-16T16:14:50Z

~~Do not merge.~~

leobalter · 2020-03-16T19:07:29Z

Ok, I had a rerun on the CI and the results look accurate now. They were previously passing on most engines but "v8 --harmony"

rwaldron · 2020-03-18T18:48:30Z

@leobalter if you have time to review this, I would appreciate that.

cc @devsnek @phoddie (who have existing implementations)

rwaldron · 2020-03-18T19:47:35Z

test/built-ins/Promise/any/capability-executor-called-twice.js

@@ -0,0 +1,106 @@
+// Copyright (C) 2019 Sergey Rubanov. All rights reserved.


I did not change anything in this file

rwaldron · 2020-03-18T19:47:42Z

test/built-ins/Promise/any/capability-executor-not-callable.js

@@ -0,0 +1,107 @@
+// Copyright (C) 2019 Sergey Rubanov. All rights reserved.


I did not change anything in this file

test/built-ins/Promise/any/ctx-non-ctor.js

test/built-ins/Promise/any/ctx-ctor-throws.js

test/built-ins/Promise/any/ctx-non-ctor.js

test/built-ins/Promise/any/does-not-perform-species-get-of-custom.js

test/built-ins/Promise/any/does-not-perform-species-get-of-promise.js

test/built-ins/Promise/any/iter-arg-is-false-reject.js

test/built-ins/Promise/any/resolve-one-mixed.js

test/built-ins/Promise/any/iter-arg-is-false-reject.js

test/built-ins/Promise/any/iter-arg-is-symbol-reject.js

test/built-ins/Promise/any/iter-assigned-symbol-reject.js

test/built-ins/Promise/any/does-not-perform-species-get-of-promise.js

test/built-ins/Promise/any/resolve-from-resolve-reject-finally.js

-

…ge for clarity)

Revisions made

leobalter · 2020-03-25T16:35:27Z

https://circleci.com/gh/tc39/test262/9909?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

LGTM, please resolve the lint errors before we land the tests.

rwaldron · 2020-03-28T01:09:34Z

@leobalter all set.

devsnek · 2020-03-28T04:00:41Z

test/built-ins/Promise/any/does-not-perform-species-get-of-custom.js

+
+class Custom extends Promise {
+  static get [Symbol.species]() {
+    throw new Test262Error('Erroneous Get(C, @@species) via SpeciesConstructor() occurred.');


Promise.prototype.then uses SpeciesConstructor

#2557 to keep track of it

devsnek · 2020-03-28T04:00:58Z

test/built-ins/Promise/any/does-not-perform-species-get-of-promise.js

+
+Object.defineProperty(Promise, Symbol.species, {
+  get() {
+    throw new Test262Error('Erroneous Get(C, @@species) via SpeciesConstructor() occurred.');


same issue here.

devsnek · 2020-03-30T05:03:13Z

test/built-ins/Promise/any/invoke-then.js

+  return boundThen(resolver, rejectElement);
+};
+
+Promise.any([promise]).then(() => $DONE(), $DONE);


promise is never resolved, so $DONE is never called, and this test always times out.

Oof, whoops. Good catch!

rwaldron mentioned this pull request Mar 16, 2020

Add Promise.any tests #2437

Closed

rwaldron force-pushed the promise-any branch from 8e72c6d to 7e61e7a Compare March 18, 2020 18:22

rwaldron changed the title ~~[WIP] Promise.any & AggregateError tests (supercedes and closes gh-2437)~~ Promise.any & AggregateError tests (supercedes and closes gh-2437) Mar 18, 2020

rwaldron commented Mar 18, 2020

View reviewed changes

rwaldron force-pushed the promise-any branch from 58f1ea8 to 3eae552 Compare March 23, 2020 19:40

leobalter previously requested changes Mar 23, 2020

View reviewed changes

rwaldron force-pushed the promise-any branch from 969e99b to 6d6ca34 Compare March 24, 2020 17:12

rwaldron requested a review from leobalter March 25, 2020 13:56

devsnek reviewed Mar 25, 2020

View reviewed changes

test/built-ins/Promise/any/does-not-perform-species-get-of-promise.js Outdated Show resolved Hide resolved

devsnek reviewed Mar 25, 2020

View reviewed changes

test/built-ins/Promise/any/resolve-from-resolve-reject-finally.js Outdated Show resolved Hide resolved

chicoxyzzy and others added 17 commits March 25, 2020 12:04

Add Capability Executor tests

715964b

Add context tests

aca1084

update features.txt

f0fd4e0

-

add Invocation of the constructor's resolve method test

23d7f0b

Add Promise and Promise.any properties tests

be1bf63

Add returns promise test

88d058b

add is callable test

adcd162

add reject-immed test

afe3f0b

add Invocation of the instance's then method test

e3d48f2

add species-get-error test

094ddc7

Add iter-arg tests

9567abd

add iter-assigned tests

860e02a

Promise.any: convert sync test to async test to ensure run to completion

e0abeaa

Promise.any: string iterable should not be rejected (adds error messa…

55b22d8

…ge for clarity)

Promise.any: expected rejection shouldn't end with error message.

47b3858

Promise.any: make async operation test actually async

272e9ab

Promise.any: empty iterable rejects with AggregateError

e0f0c78

rwaldron added 9 commits March 25, 2020 12:04

Promise.any: updates, corrections and new tests.

6edaba3

Features: remove duplicate "Promise.any"

f70e3e3

Promise.any: review fixes

5d3eafc

Promise.any: feature flags

1c74850

Promise.any: additional then + resolve tests

d9265df

Promise.any: cleanup in @@species tests

5c68b60

Promise.any: simplify promise creation

7fbce5a

Promise.any: feature flags, 2

a05fb94

Promise.any: additional "resolve from rejection" tests

b21b0c1

rwaldron force-pushed the promise-any branch from 380fff7 to b21b0c1 Compare March 25, 2020 16:04

Promise.any: review fixes, 2

499b748

Promise.any: remove unnecessary static resolve def

d53f45d

Promise.any: lint fixes

22be03d

leobalter approved these changes Mar 28, 2020

View reviewed changes

leobalter merged commit 4bf836c into master Mar 28, 2020

leobalter deleted the promise-any branch March 28, 2020 03:18

devsnek reviewed Mar 28, 2020

View reviewed changes

devsnek reviewed Mar 30, 2020

View reviewed changes

chicoxyzzy mentioned this pull request Mar 30, 2020

Add coverage for Promise.any proposal #2410

Closed

mathiasbynens mentioned this pull request Mar 30, 2020

Advance to stage 4 tc39/proposal-promise-any#4

Closed

13 tasks

leobalter mentioned this pull request Mar 30, 2020

Promise.any test bug: Promise.prototype.then uses SpeciesConstructor #2557

Closed

		@@ -0,0 +1,106 @@
		// Copyright (C) 2019 Sergey Rubanov. All rights reserved.

		@@ -0,0 +1,107 @@
		// Copyright (C) 2019 Sergey Rubanov. All rights reserved.

Promise.any & AggregateError tests (supercedes and closes gh-2437) #2533

Promise.any & AggregateError tests (supercedes and closes gh-2437) #2533

Uh oh!

Conversation

rwaldron commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leobalter commented Mar 16, 2020

Uh oh!

rwaldron commented Mar 18, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leobalter commented Mar 25, 2020

Uh oh!

rwaldron commented Mar 28, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rwaldron commented Mar 16, 2020 •

edited

Loading