Skip to content

Conversation

@hamtie
Copy link

@hamtie hamtie commented Nov 2, 2011

e.g. http://sfbay.craigslist.org/ccc/index.rss can now be parsed with the rsshandler

fb55 added 30 commits August 27, 2011 15:01
The element stack will be removed, a new event structure will be
introduced
use String#slice instead
@fb55
Copy link

fb55 commented Nov 4, 2011

Great idea. I merged it into my own fork. (Besides, I changed the code to have a better readable coding style.)

@hamtie
Copy link
Author

hamtie commented Nov 8, 2011

cool. I just merged your branch into mine. My last commit parses the feeds a little more dynamically. This undoes some of the normalization of the names, e.g. "lastBuildDate" is no longer returned as "updated" but I'm doing normalization after parsing it anyway. I might add a convenience function that automatically normalizes some of the crucial names later.

@fb55
Copy link

fb55 commented Nov 8, 2011

I like the idea to not check every single item multiple times, but normalisation is absolutely required. My idea is to rewrite the entire thing to use my EventedHandler, so that it's not necessary to build a DOM or anything.

Besides: I already opened a pull request for my own changes, so if you want to change my code, it would be easier if you fork my fork and send me a pull requests. I don't think @tautologistics is still actively developing this project, so any pull requests here will probably be forgotten.

@hamtie hamtie closed this Nov 8, 2011
fb55 added a commit to fb55/htmlparser2 that referenced this pull request Oct 21, 2018
Vatoth pushed a commit to fasterize/node-htmlparser that referenced this pull request Mar 5, 2021
Vatoth pushed a commit to fasterize/node-htmlparser that referenced this pull request Mar 5, 2021
Vatoth pushed a commit to fasterize/node-htmlparser that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants