Check for opt.$menu != null instead of opt.$menu !== null.#511
Conversation
…nts calling trigger() on an undefined object.
Member
|
Thanks for the PR! When i changed this i wondered if that might break something, thanks for the report. I would prefer to check for null and undefined then though with |
Author
|
Sure, perhaps you can do that change? I'm mostly just interested in any solution which fixes this problem for the users. |
Member
|
Yeah, will do, btw, love your work :) Saw a post on civfanatics a bit back about your application. Love civ ^^ |
Member
|
Updated and merged. :) Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents calling trigger() on an undefined object. Based on my testing opt.$menu != null should be used to check for undefined, since this fixes the actual error based on my testing.
This is related to my previous pull request here:
#462