Merged
Conversation
Extract shared components (EventChip, TimeGutter, AllDayRow, NowIndicator, UnavailabilityOverlay, SlotInteractionLayer, SelectionOverlay, hooks) from resource-grid-view into components/shared/ with generalized APIs (columnId abstraction instead of resource-specific types). Build DayGridView that shows days as columns for a date range, reusing all shared infrastructure.
Replace per-column all-day cells with a CSS subgrid container that renders all-day events as continuous blocks spanning multiple columns. A new layout algorithm computes column spans and greedy lane assignments for vertical stacking, with continuation indicators on truncated edges.
- Use Tailwind border-cal-border class on column dividers instead of inline CSS variable that wasn't being applied - Add explicit padding rows to the subgrid so dividers span the full height and eliminate the gap above the hours section - Add horizontal margin on event chips so they don't sit flush against column border lines
The flat (square) edge on truncated sides is sufficient to indicate that an event continues beyond the visible range.
Use 2px margin instead of 0 on continuation edges so events don't press flush against the column border.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource-grid-view/intocomponents/shared/with a generalizedcolumnIdabstraction instead of resource-specific typesDayGridViewcomponent that shows days as columns for a date range (e.g. a week view), reusing all shared infrastructureGridViewClassNamesbase type,DayGridViewClassNames,DayGridSelectedRange, andDayGridViewPropstypesgenerateDateRange,formatDayOfWeek,groupByDate,groupAllDayByDate,computePositionedEventsByDateTest plan
pnpm typecheck && pnpm lint:fix && pnpm buildpasses