fix some issues#5
Open
JackyLi918 wants to merge 3 commits intosvn2github:masterfrom
JackyLi918:master
Open
Conversation
JackyLi918
commented
Apr 15, 2015
JackyLi918
commented
- keeping XssfSheet.CopyRow has same behavior with Hssf.
- changing XssfWorkbook.Write() keeps the steam open for web download case.
…IHSSFListener, IERFListener; fix one issue of XWPFSetting Implementation (check-in again. main folder is missing in the last checkin)" This reverts commit e6c9e7e.
…face of IHSSFListener, IERFListener; fix one issue of XWPFSetting Implementation (check-in again. main folder is missing in the last checkin)"" This reverts commit 482a59b.
1. Keep XSSFSheet.CopyRow method has consistant behavior to HSSF. 2. change Close stream to Finish when saving XssfWorkBook to stream. this is useful for web download, so we can write workbook to Response.OutputStrean and don't cause the response ended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.