feat: port remaining squawk rules #508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+101
to
+108
| "smallint" | ||
| | "integer" | ||
| | "int2" | ||
| | "int4" | ||
| | "serial" | ||
| | "serial2" | ||
| | "serial4" | ||
| | "smallserial" |
There was a problem hiding this comment.
hab jetzt hier nur mal nen kleinen stichproben test gemacht, die anderen rules hab ich nicht angeschaut.
durch diesen check würde der error fälschlicherweise jetzt auch für integer, int4, serial, serial4 reported – vielleicht sollten wir claud sagen, dass er auch noch tests für false positives machen soll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will have claude do the work over night
closes #131
will port https://github.com/kaaveland/eugene/blob/main/eugene/src/lints/rules.rs afterwards
also added a new
agentic/dir and two newjustcommands to standardise as well as track the prompts for such work.will fix the tests, but the main part is ready for review.