feat: provide additional search_path patterns for typechecking #484
Conversation
Hmm had it there at first :D The reason I used the linter in the end was that the search_path only applies to the type checking, and to nothing else DB related. for example, if we use the EXECUTE STATEMENT feature, it'll not use those search paths. I also fear that there might be a misunderstanding that you "configure the db to use the search_path". But I don't have a strong opinion on this. What do you prefer? |
mhh what do you think of adding a new section into he settings for typechecking? That way, we can also add disable etc. linting and type checking are two different things after all. and the lint settings are used to configure individual rules. |
I think that's a good idea! I'll do it in this PR |
|
done! |
| @@ -455,6 +455,7 @@ impl Workspace for WorkspaceServer { | |||
| let path_clone = params.path.clone(); | |||
| let schema_cache = self.schema_cache.load(pool.clone())?; | |||
| let input = doc.iter(TypecheckDiagnosticsMapper).collect::<Vec<_>>(); | |||
| let search_path_patterns = settings.typecheck.search_path.clone(); | |||
There was a problem hiding this comment.
nit: why not passing the entire config struct?
There was a problem hiding this comment.
because of a circular dependency: workspace depends on typecheck, typecheck depends on workspace::TypecheckSettings
Adds a
linter.searchPathPatternsoption where a user can add glob-patterns for additional schemas to be searched when typechecking.