Mixed content error preventing jQuery from loading from the CDN#40
Open
bpainter wants to merge 1 commit intosunnywalker:masterfrom
Open
Mixed content error preventing jQuery from loading from the CDN#40bpainter wants to merge 1 commit intosunnywalker:masterfrom
bpainter wants to merge 1 commit intosunnywalker:masterfrom
Conversation
The `http` was hard coded into the examples for the jQuery CDN. When using pages as `https` jQuery will fail to load. Removed the `http` from the CDN links so it'll use either `http` or `https`.
Owner
|
I'm on the fence with this because removing the protocol causes the asset load to fail with file:// when viewing the example pages when not deployed on a server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
httpwas hard coded into the examples for the jQuery CDN. When using pages ashttpsjQuery will fail to load.Removed the
httpfrom the CDN links so it'll use eitherhttporhttps.