Update non-english language files with data from the wiki #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates to the card_db_src files in non-English languages were done programatically by a script which scrapes the dominion strategy wiki, and extracts values from the tables.
I'm putting them here in a separate PR for ease of reviewing separately. Because this is a huge change, I've used a tool called dyff to compare the before/after as JSON objects. For the most part, this is merely adding data that was not already here, but there are a few changes.
I went through most of the changes, and made an attempt to adjudicate which version was better, and updated the wiki where the version from here seemed to be a better fit. I found and fixed several clear mistakes in the wiki, then reran the script to download and parse, resulting in the second commit.
Other than additions, here are the changes by language:
The change list in Dutch is incomplete; I'll come back and finish it later. One change in Dutch that I'd appreciate the opinion of an actual Dutch-speaker on is capitalization. There were several cases where this code capitalized the last word of the name, and the wiki didn't. Which is right?
I deliberately didn't update the gzip'd versions of these files, because this won't be ready to merge until the code that can parse the wiki markup is in.
Czech:
Stash.name ± value change - Stash + Tajná skrýšThrone Room.name ± value change - Trůní sál + Trůnní sálSpy.name ± value change - Špión + ŠpionBandit Camp.name ± whitespace only change - Tábor·banditů· + Tábor·banditůFrench:
Cutpurse.name ± value change - Coupeur de bourses + Coupeur de bourseSpanish:
No changes, only additions
Italian:
+ one map entry added: Farm: │ name: Harem Conspirator.name ± value change - Cospiratore + Cospiratori Followers.name ± value change - Seguaci + SostenitoriGerman:
Nobles.name ± value change - Adelige + AdligePeddler.name ± value change - Hausierer + HausiererinRoad Network.name ± value change - Strassennetz + StraßennetzShy.name ± value change - Shy + ScheuTrader.name ± value change - Fahrender Händler + Fahrende HändlerinWarrior.name ± value change - Krieger + KriegerinWay of the Mole.name ± value change - Weg des Maulwurfs + Weg des MaulwurfesDutch:
Bad Omens.name ± value change - Slechte Voortekenen + Slechte voortekenen Bag of Gold.name ± value change - Zak met Goud + Zak met goudBasilica:
TODO: update the code with the latest from the wiki
Black Market.name ± value change - Black Market + Zwarte marktCabin Boy.name ± value change - Scheepjesjongen + ScheepsjongenLivery.name
± value change
- Stalhouderij
+ Paardenhouderij
Soldier.name
± value change
- Landknecht
+ Landsknecht