Skip to content

Conversation

@Twigz
Copy link
Collaborator

@Twigz Twigz commented Dec 9, 2025

Summary

When making a payment by bank account, the example app now provides an option between instant or standard ACH settlement speeds. We default to instant for all other payment types.

Motivation

  1. We were asked in this thread of our shared channel.
  2. Docs for new parameter.

Testing

  1. Tested with an existing bank account payment token and new bank account to make sure the ACH settlement speed option appeared.
  2. Upon creating the session, made sure that the processing time matched the option selected on the previous screen.
  3. Also ensured that credit card and apple pay options did not show the ACH settlement speed option, and defaulted to instant.
  4. Inspected the requests to make sure the parameter looked correct:

Screenshots

Screenshot_20251209_143611

@Twigz Twigz requested a review from lng-stripe December 9, 2025 19:40
@Twigz Twigz requested review from a team as code owners December 9, 2025 19:40
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 303.5 KiB │ 303.5 KiB │  0 B │ 457.7 KiB │ 457.7 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.5 KiB │   7.5 KiB │  0 B │   7.3 KiB │   7.3 KiB │  0 B 
    other │  95.2 KiB │  95.2 KiB │ -3 B │ 183.2 KiB │ 183.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.4 MiB │  11.4 MiB │ -3 B │  25.3 MiB │  25.3 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20458 │ 20458 │ 0 (+0 -0) 
   types │  6290 │  6290 │ 0 (+0 -0) 
 classes │  5051 │  5051 │ 0 (+0 -0) 
 methods │ 30674 │ 30674 │ 0 (+0 -0) 
  fields │ 17580 │ 17580 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  163 │  163 │  0   
 entries │ 3667 │ 3667 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.2 KiB │ -1 B │ 64.5 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ -1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 30.6 KiB │ -3 B │ 65.9 KiB │  0 B │ (total)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants