Skip to content
This repository was archived by the owner on Jan 31, 2024. It is now read-only.

feat: add React18 to peerDeps #100

Merged
ndelangen merged 1 commit into from
May 2, 2022
Merged

feat: add React18 to peerDeps #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"@storybook/client-api": ">=6.4.0",
"@storybook/preview-web": ">=6.4.0",
"@storybook/react": ">=6.4.0",
"react": "^16.8.0 || ^17.0.0"
Copy link
Member

@ndelangen ndelangen Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks like the proper fix to me.

I'd expect a lock-file change associated with this, @yannbf
if for testing purposes you want to stay on a particular version in this repository (whilst support any listed version) it's a good idea to add the exact version you know this repo is ran with as a devDependency too.

Copy link
Contributor Author

@alejandronanez alejandronanez Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen 👋 Just in case, I just ran yarn install locally and I didn't get any changes on my yarn.lock file.

"react": "^16.8.0 || ^17.0.0 || ^18.0.0"
},
"resolutions": {
"**/typescript": "^4.2.3"
Expand Down