Skip to content

fix(tianmu): fix up the incompatible type #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
May 26, 2023
Merged

fix(tianmu): fix up the incompatible type #1824

mergify merged 2 commits into from
May 26, 2023

Conversation

@RingsC
Copy link
Contributor

@RingsC RingsC commented May 25, 2023 •
edited
Loading

Summary about this PR

In result value setup phase, it only deals with num, but in some case, some non-num types involved, therefore, we should also deal with these types.
Issue Number: close #1808 #1788

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

This pull request's title should follow requirements next. @RingsC please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@RingsC RingsC changed the title fxi(tianmu): fix up the incompatible type fix(tianmu): fix up the incompatible type May 25, 2023
@mergify mergify bot added the PR-bug bug for pull request label May 25, 2023
@RingsC RingsC marked this pull request as ready for review May 25, 2023 13:18
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.03 ⚠️

Comparison is base (69a49bd) 55.04% compared to head (9dfe0cd) 55.01%.

❗ Current head 9dfe0cd differs from pull request most recent head d81fd36. Consider uploading reports for the commit d81fd36 to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1824      +/-   ##
===================================================
- Coverage            55.04%   55.01%   -0.03%     
===================================================
  Files                 2031     2031              
  Lines               431436   431442       +6     
===================================================
- Hits                237495   237377     -118     
- Misses              193941   194065     +124
Impacted Files Coverage Δ
storage/tianmu/core/temp_table.cpp 71.69% <81.81%> (-0.54%) ⬇️

... and 134 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

hustjieke
hustjieke approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC and others added 2 commits May 26, 2023 09:52
@RingsC
fix(tianmu): fix up the incompatible type
9dfe0cd 
1) In result value setup phase, it only deals with num, but in some case, some non-num types
involved, therefore, we should also deal with these types.

2) To fixup the boundary of the error codes.
@mergify
Merge branch 'stonedb-5.7-dev' into fix-type-incompatible-in-union-all
d81fd36
@RingsC RingsC linked an issue May 26, 2023 that may be closed by this pull request
bug(tianmu): Fix error message cannot get properly #1788
Closed
3 tasks
@mergify mergify bot merged commit 2579bd4 into stoneatom:stonedb-5.7-dev May 26, 2023
@RingsC RingsC mentioned this pull request May 26, 2023
Closed
14 tasks
@RingsC RingsC deleted the fix-type-incompatible-in-union-all branch May 26, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haitaoguan haitaoguan haitaoguan approved these changes

@adofsauron adofsauron Awaiting requested review from adofsauron

+1 more reviewer

@hustjieke hustjieke hustjieke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RingsC RingsC

Labels

PR-bug bug for pull request

Projects

None yet

Milestone

No milestone

3 participants

@RingsC @hustjieke @haitaoguan