Skip to content

Conversation

@konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented May 10, 2023

Summary about this PR

Issue Number: close #1648

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label May 10, 2023
@konghaiya konghaiya self-assigned this May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (74b5b05) 55.18% compared to head (902e6bc) 55.13%.

❗ Current head 902e6bc differs from pull request most recent head c44d07a. Consider uploading reports for the commit c44d07a to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1766      +/-   ##
===================================================
- Coverage            55.18%   55.13%   -0.05%     
===================================================
  Files                 2031     2031              
  Lines               431436   431429       -7     
===================================================
- Hits                238081   237863     -218     
- Misses              193355   193566     +211     
Impacted Files Coverage Δ
storage/tianmu/core/tianmu_table.cpp 67.84% <ø> (+0.11%) ⬆️

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit 304df8e into stoneatom:stonedb-5.7-dev May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-bug bug for pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Even if a primary key is defined, duplicate data may be imported.

3 participants