Replaced hard coded EEPROM base address with generic code #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fpr <fabien.perroquin@wi6labs.com>
ghost
requested a review
from 
ghost
added
the
fpistm
requested changes
Jul 13, 2017
Member
fpistm
left a comment
fpistm
left a comment
There was a problem hiding this comment.
Code could be factorize:
F0 and F1
F2 F4 and F7
Signed-off-by: fpr <fabien.perroquin@wi6labs.com>
Author
|
Modification done! |
fpistm
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch following a problem encountered in #56.
Hard coded addresses has been replaced with more generic code definition.
@fpistm the F7 and F2 need to be tested! Other are OK.