Update localhost and private IP validations#5126
Open
neatzsche wants to merge 1 commit intostellar:masterfrom
Open
Update localhost and private IP validations#5126neatzsche wants to merge 1 commit intostellar:masterfrom
neatzsche wants to merge 1 commit intostellar:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the security of peer address validation by expanding localhost detection and adding link-local address filtering. The changes prevent nodes from accepting peer addresses in the full loopback range (127.x.y.z) instead of just 127.0.0.1, and also reject link-local addresses (169.254.x.y) as private addresses that should not be advertised across the network.
Changes:
- Expanded
isLocalhost()to detect the entire 127.x.y.z loopback range using bit-shift validation - Added link-local address range (169.254.x.y) to
isPrivate()validation
6876b88 to
0f21898
Compare
0f21898 to
bb354c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents a node from accepting localhost peers from another peer that provides a peer address that is in the loopback address range that isn't just
127.0.0.1. Also extends isPrivate() validation to prevent accepting a link-local peer.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)