Add --disable-tests build validation to CI and fix ci-build.sh bug#5079
Draft
Add --disable-tests build validation to CI and fix ci-build.sh bug#5079
Conversation
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add build step for CI with --disable-tests
Add --disable-tests build validation to CI
Dec 18, 2025
Contributor
|
@copilot looks like there's an existing bug in ci-build.sh where --disable-tests isn't added to |
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Author
Fixed in commit afc2c9c. Added |
Copilot
AI
changed the title
Add --disable-tests build validation to CI
Add --disable-tests build validation to CI and fix ci-build.sh bug
Dec 18, 2025
sisuresh
reviewed
Dec 18, 2025
Contributor
|
@copilot can you add a matrix to run this for both current and next? |
Co-authored-by: sisuresh <5050166+sisuresh@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI currently only builds with tests enabled, allowing code with test-only dependencies to pass validation and break Jenkins production builds configured with
--disable-tests.Changes
build-without-testsjob that builds with--disable-testsusing GCC compiler with both current and next protocols (using matrix strategy)completejob to require the new build job before marking CI as successful--disable-testsflag was not being passed to the configure script. The script now properly adds--disable-teststoconfig_flagsfollowing the same pattern asDISABLE_POSTGRES.The new job follows the same structure as existing
build-linuxjobs. With the ci-build.sh fix, the--disable-testsflag is now correctly passed to the configure script, which properly disables building tests via theAM_CONDITIONAL(BUILD_TESTS)check.Original prompt
--disable-tests#5078✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.