Error if footprint has expired entry#3824
Merged
latobarita merged 5 commits intostellar:masterfrom Jul 12, 2023
Merged
Conversation
dmkozh
reviewed
Jul 11, 2023
Contributor
dmkozh
left a comment
dmkozh
left a comment
There was a problem hiding this comment.
We need the same check for the bump footprint op
Contributor
Author
I don't think we do. We only load live entries there. |
Contributor
Oh, right, that's fine, though a bit inconsistent. |
dmkozh
reviewed
Jul 11, 2023
Contributor
|
r+ bef8df4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempting to access an expired persistent entry should result in an error.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)