Skip to content

Conversation

rajanarahul93
Copy link
Contributor

Resolves #7019.

Description

What is the purpose of this pull request?

This pull request:

  • fixes JavaScript lint errors by replacing new Array() constructor with array literal syntax to comply with the stdlib/no-new-array ESLint rule in the svg marks component

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Technical Details:

  • File changed: lib/node_modules/@stdlib/plot/components/svg/marks/lib/main.js
  • Line 114: Replaced args = new Array( arguments.length+1 ); with args = []; args.length = arguments.length + 1;
  • ESLint rule: stdlib/no-new-array
  • Functionality: Maintains identical behavior while following stdlib coding standards
  • Testing: Verified with make lint-javascript-files command

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Aug 24, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 28, 2025
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Aug 28, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Aug 29, 2025
@kgryte
Copy link
Member

kgryte commented Aug 29, 2025

As the CI failure does not appear to stem from changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit dbc0f86 into stdlib-js:develop Aug 29, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants