Fix audit middleware to always restore request body #3060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small bug I found when testing the vMCP audit middleware manually like a caveman made me forget to set an explicit maxDataSize - turns out that auditing didn't work without the data size being set explicitly at all.
The audit middleware was consuming the request body but only restoring it when the body size was within MaxDataSize. This caused downstream handlers to receive an empty body when the size limit was exceeded.
The original condition appears to have been a bug rather than intentional:
Now the body is always restored after reading, and size checking only affects whether the data is captured for audit logging. This matches the pattern used for response data capture.