-
Notifications
You must be signed in to change notification settings - Fork 160
Deprecate SSE proxy mode for stdio transport #3008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate SSE proxy mode for stdio transport #3008
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3008 +/- ##
==========================================
- Coverage 56.39% 56.39% -0.01%
==========================================
Files 333 333
Lines 33002 33002
==========================================
- Hits 18612 18610 -2
- Misses 12809 12811 +2
Partials 1581 1581 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4c96b3 to
fe8f558
Compare
Add deprecation notices for the SSE proxy mode which will be removed in a future release. Users should migrate to streamable-http (now the default). Changes: - Add runtime warning when --proxy-mode sse is explicitly used - Update help text to indicate SSE is deprecated - Add Deprecated comment to ProxyModeSSE constant - Update CLI, CRD, and API documentation - Extract sseSuffix constant in inspector.go to satisfy linter Signed-off-by: carlos <21148423+carlos-gn@users.noreply.github.com>
fad4935 to
b06ddc8
Compare
eleftherias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great once again @carlos-gn! Thanks!
Summary
Add deprecation notices for the SSE proxy mode which will be removed in a future release. Users should migrate to streamable-http (now the default).
Changes:
Fixes: #2540