Skip to content

Conversation

@carlos-gn
Copy link
Contributor

Summary

Add deprecation notices for the SSE proxy mode which will be removed in a future release. Users should migrate to streamable-http (now the default).

Changes:

  • Add runtime warning when --proxy-mode sse is explicitly used
  • Update help text to indicate SSE is deprecated
  • Add Deprecated comment to ProxyModeSSE constant
  • Update CLI, CRD, and API documentation
  • Extract sseSuffix constant in inspector.go to satisfy linter

Fixes: #2540

image

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.39%. Comparing base (02f494d) to head (42e34ab).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
- Coverage   56.39%   56.39%   -0.01%     
==========================================
  Files         333      333              
  Lines       33002    33002              
==========================================
- Hits        18612    18610       -2     
- Misses      12809    12811       +2     
  Partials     1581     1581              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlos-gn carlos-gn force-pushed the feat/deprecate-sse-proxy-mode-for-stdio-transport branch from a4c96b3 to fe8f558 Compare December 11, 2025 22:59
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 11, 2025
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 11, 2025
  Add deprecation notices for the SSE proxy mode which will be removed
  in a future release. Users should migrate to streamable-http (now the
  default).

  Changes:
  - Add runtime warning when --proxy-mode sse is explicitly used
  - Update help text to indicate SSE is deprecated
  - Add Deprecated comment to ProxyModeSSE constant
  - Update CLI, CRD, and API documentation
  - Extract sseSuffix constant in inspector.go to satisfy linter

Signed-off-by: carlos <21148423+carlos-gn@users.noreply.github.com>
@carlos-gn carlos-gn force-pushed the feat/deprecate-sse-proxy-mode-for-stdio-transport branch from fad4935 to b06ddc8 Compare December 11, 2025 23:19
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 11, 2025
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 12, 2025
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 12, 2025
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 12, 2025
Copy link
Member

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great once again @carlos-gn! Thanks!

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 12, 2025
@eleftherias eleftherias merged commit 08735de into stacklok:main Dec 12, 2025
29 checks passed
@carlos-gn carlos-gn deleted the feat/deprecate-sse-proxy-mode-for-stdio-transport branch December 12, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate SSE proxy mode for stdio transport

2 participants