Skip to content

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jan 11, 2024

Description

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@NickLarsenNZ NickLarsenNZ force-pushed the chore/bump-operator-rs-0.60.1 branch from ebae1ae to d882f2d Compare January 11, 2024 13:07
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review January 11, 2024 15:04
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jan 11, 2024

Running kuttl tests in Azure...

☑️ Passed (nightly suite)

sbernauer
sbernauer previously approved these changes Jan 11, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 60a9a18 Jan 12, 2024
@NickLarsenNZ NickLarsenNZ deleted the chore/bump-operator-rs-0.60.1 branch January 12, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants