Skip to content

Conversation

@lfrancke
Copy link
Member

@lfrancke lfrancke commented Jul 1, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@lfrancke lfrancke self-assigned this Jul 1, 2024
@lfrancke lfrancke marked this pull request as ready for review July 11, 2024 09:58
@maltesander maltesander self-requested a review July 11, 2024 09:58
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things. LGTM otherwise. Will start the test once built is done.

@lfrancke lfrancke requested a review from maltesander July 11, 2024 10:15
@maltesander
Copy link
Member

@maltesander
Copy link
Member

@maltesander
Copy link
Member

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked the product versions against the spreadsheet

@lfrancke lfrancke added this pull request to the merge queue Jul 23, 2024
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked if no test was forgotten and on typos, tests have been done by the author.

LGTM! Thank you.

Merged via the queue into main with commit 26bcb6d Jul 23, 2024
@lfrancke lfrancke deleted the feat/24.7 branch July 23, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants