-
-
Notifications
You must be signed in to change notification settings - Fork 3
[Merged by Bors] - OpenShift compatibility #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwk67
approved these changes
Aug 16, 2022
Member
adwk67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
(maybe just add a line somewhere about the need to have the correctly labelled nodes in OS for the PVC tests to work).
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
Part of: stackabletech/issues#234 All tests pass in Jenkins (with k3s): https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/22/ NOTE: For the dag tests, one needs to turn the `openshift` dimension to `true` in `test-definition.yaml`.
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: stackabletech/issues#234
All tests pass in Jenkins (with k3s): https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/22/
NOTE: For the dag tests, one needs to turn the
openshiftdimension totrueintest-definition.yaml.