Skip to content

Conversation

@dbpolito
Copy link
Contributor

Fixing an error on Pull Request Event that for some reason i missed...

TypeError: undefined is not an object (evaluating 'payload.pull_request')
      at src/cli/cmd/github.ts:414:14
      at src/cli/cmd/github.ts:387:36
      at src/cli/bootstrap.ts:10:30
      at fn (src/cli/bootstrap.ts:8:9)
      at src/project/instance.ts:36:45
      at run (node:async_hooks:62:22)
      at processTicksAndRejections (unknown:7:39)

I also tested the Schedule event and seems to be working just fine too.

@rekram1-node
Copy link
Collaborator

/review

import * as github from "@actions/github"
import type { Context } from "@actions/github/lib/context"
import type { IssueCommentEvent, PullRequestReviewCommentEvent, PullRequestEvent } from "@octokit/webhooks-types"
import type { IssueCommentEvent, PullRequestReviewCommentEvent, WorkflowRunEvent, PullRequestEvent } from "@octokit/webhooks-types"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion: The WorkflowRunEvent import was added but workflow_run is not in SUPPORTED_EVENTS (line 130). Consider removing this unused import, or if you plan to support workflow_run events in the future, you may want to add it to the supported events array. This is a very minor nit and the code will work fine either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schedule event triggers WorkflowRunEvent

@github-actions
Copy link
Contributor

lgtm

@rekram1-node rekram1-node merged commit ab2a6c4 into sst:dev Dec 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants