feat(tui): console copy-to-clipboard via opentui #5658
Merged
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The click-to-copy feature would fail when console was visible but unfocused because the state tracker assumed toggle() was a simple on/off, but opentui's toggle() has 3 states: - hidden → show+focus - visible+focused → hide - visible+unfocused → focus (stays visible!) When user toggled an unfocused console, the old code would flip consoleOpen to false even though the console remained visible, breaking the click detection. Now tracks both visible AND focused state to match opentui's actual behavior, ensuring click-to-copy works reliably. Closes sst#4885
- Update @opentui/core and @opentui/solid to 0.1.61 - Replace manual click-to-copy with opentui's onCopySelection callback - Remove MouseParser and console state tracking (now handled by opentui) - Simplify toggle console command Depends on sst/opentui#411 (merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4885
Supersedes #5239 — uses opentui's new
onCopySelectioncallback from sst/opentui#411.Changes
@opentui/coreand@opentui/solidto0.1.61renderer.console.onCopySelectioncallback for clipboard integrationMouseParserimplementation (now handled by opentui)Features (from opentui)
Ctrl+Shift+Cto copy selectionContext: #4885 (comment)