Implement macOS support using sandbox-exec and refactor for multi-platform support

.github/workflows/test.yml

@@ -0,0 +1,24 @@
+name: Tests
+
+on:
+  push:
+    branches: [main, master]
+  pull_request:
+
+jobs:
+  test:
+    strategy:
+      matrix:
+        os: [macos-latest, ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Nix
+        uses: nixbuild/nix-quick-install-action@v34
+
+      - name: Install just
+        uses: extractions/setup-just@v2
+
+      - name: Run tests
+        run: just test

examples/claude-sandboxed/flake.nix

@@ -2,7 +2,7 @@
   inputs = {
     nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable";
     flake-parts.url = "github:hercules-ci/flake-parts";
-    landrun-nix.url = "github:srid/landrun-nix";
+    landrun-nix.url = "path:../../";
   };
 
   outputs = inputs@{ flake-parts, landrun-nix, ... }:
@@ -18,6 +18,7 @@
         };
 
         landrunApps.default = {
+          name = "claude";
           imports = [
             landrun-nix.landrunModules.gh # So, Claude can run `gh` CLI
             landrun-nix.landrunModules.git # So, Claude can run `git` CLI

justfile

@@ -1,3 +1,15 @@
 # Run the claude-sandboxed example with local landrun-nix override
 run-example:
     nix run ./examples/claude-sandboxed --override-input landrun-nix .
+
+# Run integration tests
+test:
+    #!/usr/bin/env bash
+    if [ "$(uname)" = "Darwin" ]; then
+      # macOS: BSD script syntax: script -q <output> <command>
+      SCRIPT_ARGS="-q /dev/null ./tests/test.bats"
+    else
+      # Linux: util-linux script syntax: script -qec <command> <output>
+      SCRIPT_ARGS="-qec ./tests/test.bats /dev/null"
+    fi
+    nix develop ./tests --override-input landrun-nix path:./. -c script $SCRIPT_ARGS

modules/flake-parts/landrun/common/features.nix

@@ -0,0 +1,63 @@
+{ lib, config, ... }:
+{
+  config = {
+    # Auto-configure CLI options based on high-level flags
+    cli = lib.mkMerge [
+      # TTY support
+      (lib.mkIf config.features.tty {
+        rw = [
+          "/dev/null"
+          "/dev/tty"
+        ];
+        rox = [
+          "/dev/zero"
+          "/dev/random"
+          "/dev/urandom"
+          "/usr/share/terminfo"
+        ];
+        env = [
+          "TERM"
+          "SHELL"
+          "COLORTERM"
+          "LANG"
+          "LC_ALL"
+        ];
+      })
+
+      # Nix support
+      (lib.mkIf config.features.nix {
+        rox = [
+          "/nix"
+          "/usr"
+          "/lib"
+        ];
+        rw = [
+          "$HOME/.cache/nix"
+        ];
+        ro = [
+          "/etc/nix"
+          "$HOME/.local/share/nix"
+        ];
+        env = [
+          "PATH" # Required for programs to find executables
+          "NIX_PATH"
+          "NIX_SSL_CERT_FILE"
+        ];
+      })
+
+      # Network support
+      (lib.mkIf config.features.network {
+        rox = [
+          "/etc/resolv.conf"
+          "/etc/ssl"
+        ];
+        unrestrictedNetwork = true;
+      })
+
+      # Tmp support
+      (lib.mkIf config.features.tmp {
+        rwx = [ "/tmp" ];
+      })
+    ];
+  };
+}

modules/flake-parts/landrun/darwin/features.nix

@@ -0,0 +1,28 @@
+{ lib, config, pkgs, ... }:
+{
+  config = lib.mkIf pkgs.stdenv.isDarwin {
+    cli = lib.mkMerge [
+      # TTY support
+      (lib.mkIf config.features.tty {
+        rox = [
+          "/etc/profile" # Shell initialization
+        ];
+      })
+
+      # Nix support
+      (lib.mkIf config.features.nix {
+        rox = [
+          "/bin"
+        ];
+        ro = [
+          "/var/run/syslog" # Often needed for logging on macOS
+        ];
+      })
+
+      # Tmp support
+      (lib.mkIf config.features.tmp {
+        rwx = [ "/var/folders" ];
+      })
+    ];
+  };
+}

modules/flake-parts/landrun/darwin/wrapper.nix

@@ -0,0 +1,157 @@
+{ lib, config, pkgs, ... }:
+let
+  pkg = pkgs.writeShellApplication {
+    name = config.name;
+    runtimeInputs = [ pkgs.coreutils ];
+    text = ''
+      user=''${USER:-nobody}
+      PROFILE_FILE=$(mktemp "/tmp/sandbox-profile-$user-XXXXXX.sb")
+      trap 'rm -f "$PROFILE_FILE"' EXIT
+
+      cat > "$PROFILE_FILE" <<EOF
+      ;; Sandbox Profile Language (SBPL) version 1
+      (version 1)
+
+      ;; Default deny policy: Everything is denied unless explicitly allowed
+      (deny default)
+
+      ;; Allow forking child processes (essential for shell wrappers and most apps)
+      (allow process-fork)
+
+      ;; Allow sending signals to processes
+      (allow signal)
+
+      ;; Import standard system profile
+      ;; This is required for basic system functionality:
+      ;; - Dynamic linker (dyld) operation
+      ;; - System frameworks and libraries (libc, libSystem, etc.)
+      ;; - Basic kernel interactions (mach lookups, sysctls)
+      ;; Without this, almost no binary can execute on macOS.
+      (import "system.sb")
+
+      ;; Allow broad metadata access
+      ;; 'file-read-metadata' is needed for:
+      ;; - 'ls' (directory listing implies metadata read)
+      ;; - 'getcwd' path resolution
+      ;; - 'realpath' and symlink resolution
+      ;; 'file-test-existence' is needed for:
+      ;; - Library probing (dyld checking potential paths)
+      ;; - Applications checking for optional config files
+      ;; Note: This allows seeing *if* files exist, but not reading their content.
+      (allow file-read-metadata)
+      (allow file-test-existence)
+
+      ;; Standard POSIX device nodes
+      ;; Most applications expect these to be available.
+      (allow file-read*
+        (literal "/dev/null")
+        (literal "/dev/zero")
+        (literal "/dev/random")
+        (literal "/dev/urandom"))
+
+      ${lib.optionalString config.features.tty ''
+      ;; Allow PTY ioctls (enabled by features.tty)
+      ;; Necessary for interactive applications (stty, shells, REPLs) to control the terminal.
+      (allow file-ioctl (regex #"^/dev/ttys[0-9]+"))
+      ''}
+
+      ;; Network Access Control
+      ;; Based on 'features.network' or 'cli.unrestrictedNetwork'
+      ${if config.cli.unrestrictedNetwork then "(allow network*)" else "(deny network*)"}
+
+      ;; Filesystem Access Control
+      ;; Based on 'cli.unrestrictedFilesystem'
+      ${if config.cli.unrestrictedFilesystem then "(allow file*)" else ""}
+
+      EOF
+
+      # Isolation of environment variables (like landrun does)
+      ALLOWED_VARS=(${lib.concatStringsSep " " (map (e: "\"${e}\"") config.cli.env)})
+      KEEP_VARS=("HOME" "USER" "LOGNAME" "PATH" "TERM" "SHELL" "LANG" "LC_ALL" "DISPLAY")
+
+      ENV_ARGS=()
+      for var in "''${ALLOWED_VARS[@]}" "''${KEEP_VARS[@]}"; do
+         # Check if variable is set
+         if [[ -v "$var" ]]; then
+            ENV_ARGS+=("$var=''${!var}")
+         fi
+      done
+
+      # Function to add paths to SBPL profile
+      add_paths() {
+        local op=$1
+        shift
+        for p in "$@"; do
+          # Expand $HOME and $UID if present in path
+          p_expanded=''${p//\$HOME/$HOME}
+          p_expanded=''${p_expanded//\$UID/$(id -u)}
+
+          # Make path absolute if it's relative
+          if [[ "$p_expanded" != /* ]]; then
+            p_expanded="$(pwd -P)/$p_expanded"
+          fi
+
+          if [ -e "$p_expanded" ]; then
+            # Resolve to real path for macOS sandbox
+            p_real=$(${lib.getExe pkgs.perl} -e 'use Cwd "abs_path"; print abs_path(shift)' "$p_expanded")
+
+            case "$op" in
+              rox)
+                echo "(allow file-read* (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                echo "(allow process-exec (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                ;;
+              ro)
+                echo "(allow file-read* (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                ;;
+              rw)
+                echo "(allow file-read* (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                echo "(allow file-write* (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                echo "(allow file-ioctl (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                ;;
+              rwx)
+                echo "(allow file-read* (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                echo "(allow file-write* (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                echo "(allow file-ioctl (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                echo "(allow process-exec (subpath \"$p_real\"))" >> "$PROFILE_FILE"
+                ;;
+            esac
+          fi
+        done
+      }
+
+      # Fix getcwd by allowing traversal of parents
+      # Use physical path for CURR_PATH
+      CURR_PATH="$(pwd -P)"
+      while [ "$CURR_PATH" != "/" ]; do
+        echo "(allow file-read* (literal \"$CURR_PATH\"))" >> "$PROFILE_FILE"
+        CURR_PATH=$(dirname "$CURR_PATH")
+      done
+
+      ${lib.optionalString config.cli.addExec ''
+        echo "(allow file-read* (literal \"${config.program}\"))" >> "$PROFILE_FILE"
+        echo "(allow process-exec (literal \"${config.program}\"))" >> "$PROFILE_FILE"
+      ''}
+
+      # shellcheck disable=SC2016
+      ${lib.optionalString (config.cli.rox != []) "add_paths rox ${lib.escapeShellArgs config.cli.rox}\n"}
+      # shellcheck disable=SC2016
+      ${lib.optionalString (config.cli.ro != []) "add_paths ro ${lib.escapeShellArgs config.cli.ro}\n"}
+      # shellcheck disable=SC2016
+      ${lib.optionalString (config.cli.rw != []) "add_paths rw ${lib.escapeShellArgs config.cli.rw}\n"}
+      # shellcheck disable=SC2016
+      ${lib.optionalString (config.cli.rwx != []) "add_paths rwx ${lib.escapeShellArgs config.cli.rwx}\n"}
+
+      # Execute with isolated environment
+      exec env -i "''${ENV_ARGS[@]}" sandbox-exec -f "$PROFILE_FILE" ${config.program} "$@"
+    '';
+  };
+in
+{
+  config = lib.mkIf pkgs.stdenv.isDarwin {
+    wrappedPackage =
+      if config.cli.extraArgs != [ ] then
+        lib.warn "landrun-nix: extraArgs are ignored on Darwin as sandbox-exec does not support them." pkg
+      else
+        pkg;
+  };
+}

modules/flake-parts/landrun/default.nix

@@ -17,7 +17,7 @@ in
           apps = lib.mapAttrs
             (name: cfg: {
               type = "app";
-              program = "${cfg.wrappedPackage}/bin/${name}";
+              program = lib.getExe cfg.wrappedPackage;
               meta = cfg.meta;
             })
             config.landrunApps;