Add validation to Owner telephone field #2177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kriti20041 <kritia2004@gmail.com>
kriti20041
force-pushed
the
improve-readme-or-validation
branch
from
754faa0 to
7b9760c
Compare
|
|
||
| @NotBlank | ||
| @Pattern(regexp = "\\d{10}", message = "Telephone must be a 10-digit number") | ||
| @Column(name = "telephone") |
Contributor
There was a problem hiding this comment.
Why here in the getter?
There is already validation on the field.
andrzejsydor
suggested changes
Dec 25, 2025
Contributor
andrzejsydor
left a comment
andrzejsydor
left a comment
There was a problem hiding this comment.
the PR is not complete, no tests, no value, imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to the Owner.telephone field to ensure it is not blank
and contains a valid 10-digit number. This improves data integrity and user input validation.