fix(system): avoid intentional RuntimeException in CrashController for local runs #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranayyyy6
force-pushed
the
fix/no-crash-endpoint
branch
2 times, most recently
from
b69f609 to
af19f3a
Compare
…r local runs Signed-off-by: Pranay <boddupranay8@gmail.com>
pranayyyy6
force-pushed
the
fix/no-crash-endpoint
branch
from
af19f3a to
f44f87f
Compare
Member
|
The whole point of /oups is to test the error handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the CrashController to avoid throwing an intentional RuntimeException when accessing the /oups endpoint. The method now redirects to the home page instead of failing.
Why
The original behavior is meant to demonstrate exception handling, but for newcomers running the project locally it can be confusing. This change improves the local developer experience while keeping the demo simple.
Changes
triggerException()withreturn "redirect:/".Implementation note
The original endpoint threw a RuntimeException to demonstrate exception handling in the demo.
This change preserves the intent (no production logic change) while preventing surprise errors during local experimentation.
Testing
/oupsreturns a 302 redirect to/.