This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Apply AssertJ and JUnit 5 best practices #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
suggested changes
Dec 24, 2024
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Well, thank you for contribution, but let's see if we can make it better!
Or reviewing ourselves after the bot run, or improve such a bot.
WDYT?
...ava/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java
Show resolved
Hide resolved
...ava/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java
Show resolved
Hide resolved
...ava/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/integration/aws/outbound/SnsMessageHandlerTests.java
Outdated
Show resolved
Hide resolved
rickie
changed the title
For details on the recipe, see https://docs.openrewrite.org/recipes/java/testing/assertj/assertj-best-practices Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.assertj.Assertj?organizationId=U3ByaW5n Co-authored-by: Moderne <team@moderne.io>
rickie
force-pushed
the
refactor/assert-j-best-practices
branch
from
ab350fb to
9d74a5b
Compare
rickie
changed the title
artembilan
suggested changes
Dec 26, 2024
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Thanks for the update!
Unfortunately there is still something off:
/home/runner/work/spring-integration-aws/spring-integration-aws/src/test/java/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java:190: error: cannot find symbol
String record = payload.getFirst();
^
symbol: method getFirst()
location: variable payload of type List<String>
1 error
Please, consider to run ./gradlew check locally before pushing.
timtebeek
reviewed
Dec 26, 2024
src/test/java/org/springframework/integration/aws/outbound/SqsMessageHandlerTests.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Dec 26, 2024
...ava/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Dec 27, 2024
...ava/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Dec 27, 2024
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Great to see! One last suggestion from my side; and indeed some possible improvements for recipes still.
Member
|
Thank you for contribution; looking forward for more! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.assertj.Assertj?organizationId=U3ByaW5n
This PR is created on Moderne and applies some AssertJ best practices on the codebase.
Let me know if you disagree with any of the changes, I can update the PR if needed.
CC: @timtebeek