Docs: Rework mvc-jsp section with JavaConfig example (per review feedback)#35444
Closed
Dongnyoung wants to merge 5 commits intospring-projects:mainfrom
Closed
Docs: Rework mvc-jsp section with JavaConfig example (per review feedback)#35444Dongnyoung wants to merge 5 commits intospring-projects:mainfrom
Dongnyoung wants to merge 5 commits intospring-projects:mainfrom
Conversation
…ttpRequest This pull request fixes a grammatical mistake in the JavaDoc of the setResponse method in MockClientHttpRequest. - Original: "the this request" - Changed to: "this request" This change improves the clarity and quality of the documentation. Signed-off-by: DongNyoung Lee <121621378+Dongnyoung@users.noreply.github.com>
Fix grammatical error in JavaDoc of setResponse method in MockClientHttpRequest.
Signed-off-by: DongNyoung Lee <121621378+Dongnyoung@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: DongNyoung Lee <121621378+Dongnyoung@users.noreply.github.com>
sdeleuze
added
type: documentation
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Sep 9, 2025
See spring-projectsgh-35444 Signed-off-by: DongNyoung Lee <121621378+Dongnyoung@users.noreply.github.com>
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
Sep 9, 2025
This commit ensures consistency with the documentation of other view resolvers. See spring-projectsgh-35444
Contributor
Author
|
The maintainer moved this into #35450 and closed it there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #35430
Summary
This PR reworks the mvc-jsp section following the review feedback:
<bean>declaration with a higher-level JavaConfigconfigureViewResolvers(ViewResolverRegistry registry)snippet as the default example.<mvc:view-resolvers>XML example within a note for legacy configuration.Motivation
As suggested in the review, this section is not the right place to document low-level defaults.
By focusing on configuration style and best practices, while still covering XML for legacy users, the documentation stays concise and aligned with Spring’s reference doc guidelines.