This repository was archived by the owner on Dec 11, 2025. It is now read-only.
"fix" ☠ Unknown ID trash. Inconsitent meta data#18
Closed
nemiah wants to merge 1 commit intosplitbrain:masterfrom
Closed
"fix" ☠ Unknown ID trash. Inconsitent meta data#18nemiah wants to merge 1 commit intosplitbrain:masterfrom
nemiah wants to merge 1 commit intosplitbrain:masterfrom
Conversation
ohad
reviewed
Dec 29, 2020
| { | ||
| if (!isset($this->index[$id])) throw new \Exception("Unknown ID $id. Inconsitent meta data"); | ||
| if($id == "trash") | ||
| return ""; |
There was a problem hiding this comment.
Here's a proposed different fix. Later, change as follows:
if ($item['Parent'] === '') {
// top level item
$item['Path'] = '/' . $item['VissibleName'];
+ } else {if ($item['Parent'] === 'trash') {
+ // trash item
+ $item['Path'] = 'trash/' . $item['VissibleName'];
} else {
// recursion
$item['Path'] = $this->calcPath($item['Parent']) . '/' . $item['VissibleName'];
- }
+ }}This doesn't actually work (though it stops crashing on my machine), but the point is to return a sensible path rather than an empty path.
(Unless the empty path is actually correct --- I'm not an expert in this API, just proposing a slightly different way to do this.)
Contributor
Author
There was a problem hiding this comment.
No problem, I just needed a solution that works and I thougt I'd share it if someone is interested 😊 I don't know either what's the right solution here 🤷♀️
splitbrain
added a commit
that referenced
this pull request
Jun 3, 2021
This is a somewhat ugly workaround for the 'trash' folder problem mentioned in #18, but it works fine so far.
Owner
|
I pushed a different workaround, so I'm closing this. I guess proper trash support would be cool. PRs welcome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i got the error "☠ Unknown ID trash. Inconsitent meta data" when uploading a pdf file.
Looks like a trash was added a while ago. I don't know if this "fix" does break something else, uploads work again for me 🤷♀️ 😊
Best,
Nena