Updated Reloading Scheme for ReloadableDLL#2218
Merged
Conversation
phschaad
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the reloading scheme used by
ReloadableDLL.If the library (of the compiled SDFG) is already loaded, through another instance of
CompiledSDFGthenReloadableDLLwill copy the SDFG library and try to load that until it founds a name that is free.In ICON4Py we noticed that this leads sometime to a segmentation fault on Linux, but not on MacOS X.
We traced the main issue down to the fact that
ReloadableDLLcreated a copy of the SDFG library without checking if the new name is already used, instead the file is simply overwritten.The new scheme changes this slightly, in the following ways:
n - 1tonit always makes a copy from the initial library.