Skip to content

dace.data Refactoring Incomplete #2290

@philip-paul-mueller

Description

@philip-paul-mueller

The recent refactoring of dace.data generated some inconsistencies.

  • While find_new_name() was moved into dace.utils almost all parts of the code still refers to the dace.data.find_new_name() alias, which is provided for backwards compatibility.
  • The Data class provides the strides_from_layout method which allows to compute strides based on a shape, which is kind of okay since it does not mutate any values and only reads the shape, despite the fact that Data does not have a concept of strides (it does not have a strides property only the Array has something like that). However, it also has the set_strides_from_layout function which creates a strides attribute on the object. However, with the exception of the Array this property is not serialized. Therefore, this method does not belong to Data and should be moved to Array the only logical place.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions