-
Notifications
You must be signed in to change notification settings - Fork 155
Open
Description
The recent refactoring of dace.data generated some inconsistencies.
- While
find_new_name()was moved intodace.utilsalmost all parts of the code still refers to thedace.data.find_new_name()alias, which is provided for backwards compatibility. - The
Dataclass provides thestrides_from_layoutmethod which allows to compute strides based on a shape, which is kind of okay since it does not mutate any values and only reads the shape, despite the fact thatDatadoes not have a concept of strides (it does not have astridesproperty only theArrayhas something like that). However, it also has theset_strides_from_layoutfunction which creates astridesattribute on the object. However, with the exception of theArraythis property is not serialized. Therefore, this method does not belong toDataand should be moved toArraythe only logical place.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels