Support for limiting streams (Pekko, Akka, fs2, zio-streams) #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kciesielski
changed the title
adamw
reviewed
Nov 21, 2023
akka/src/test/scala/sttp/capabilities/akka/AkkaStreamsTest.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Nov 21, 2023
core/src/main/scala/sttp/capabilities/StreamMaxLimitExceeded.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Nov 21, 2023
adamw
reviewed
Nov 21, 2023
adamw
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition introduces a
limitBytesstream wrapper, which fails the stream if byte count exceeds given limit.It was inspired by softwaremill/tapir#3056
With this operation available for multiple streaming implementations, we can enhance streaming body support in Tapir, so that many backends get support for limiting content length for individual endpoints.
Vertx and Armeria implementations are left for later.
Monix, fs2-ce2, and zio1 are left out, as these libraries are quite outdated anyway.