algorithms: generalizer to help handle extremely large models in more generalized form #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMixu
approved these changes
Jan 10, 2025
Contributor
NotMixu
left a comment
NotMixu
left a comment
There was a problem hiding this comment.
Looks good to me, pointed out some minor things.
src/sgraph/algorithms/generalizer.py
Outdated
Comment on lines
36
to
37
| have_element_attrs = True | ||
| have_dep_attrs = False |
Contributor
There was a problem hiding this comment.
These values are never changed. Is that intentional?
src/sgraph/algorithms/generalizer.py
Outdated
| return generalized_model | ||
|
|
||
|
|
||
| def copy_model_and_build_map(LEVEL, generalized_model, model, have_element_attrs): |
Contributor
There was a problem hiding this comment.
Could add type hints here, even though it is utility function not directly used by the user.
src/sgraph/algorithms/generalizer.py
Outdated
| generalized_model = SGraph() | ||
| old_to_old = {} | ||
|
|
||
| def recuse_elements(elem, level, last_element_on_desired_level): |
… generalized form
villelaitila
force-pushed
the
You_will_pass_away_very_quickly
branch
from
0af93ea to
da2e33b
Compare
Looking good 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizer removes elements in the model beyond given depth level parameter, so that the associations get transferred to the most closest remaining ancestor element.