Improve typings of most of the important stuff #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
villelaitila
left a comment
villelaitila
left a comment
There was a problem hiding this comment.
Good work, improves the maintainability a lot
villelaitila
reviewed
Nov 1, 2024
| """ | ||
| ignored_attributes = ignored_attributes or [] | ||
|
|
||
| extracted_paths = [] |
Contributor
There was a problem hiding this comment.
Yes, can be removed, and also the for loop that iterates it.
villelaitila
reviewed
Nov 1, 2024
src/sgraph/compare/modelcompare.py
Outdated
| def compare(self, path1, path2): | ||
| def compare(self, path1: str, path2: str): | ||
| #? What should be the correct implementation here? This doesn't seem to be correct. | ||
| model1 = SGraph(path1) |
Contributor
There was a problem hiding this comment.
I think this would be the correct way in this function
model1 = SGraph.parse_xml_or_zipped_xml(path1)
model2 = SGraph.parse_xml_or_zipped_xml(path2)
villelaitila
reviewed
Nov 1, 2024
src/sgraph/modelapi.py
Outdated
| raise ValueError("Either filepath or model must be provided") | ||
|
|
||
| self.egm = model | ||
| #? Is this intentionally "model" and not "self.model"? |
Contributor
There was a problem hiding this comment.
good find, should be self.model
villelaitila
reviewed
Nov 1, 2024
src/sgraph/modelapi.py
Outdated
| def getUsedElements(self, elem: SElement): | ||
| associations = [x for x in elem.outgoing] | ||
| return set(map(lambda x: x.fromElement, associations)) | ||
| #? Is this intentionally "fromElement" and not "toElement"? |
Contributor
There was a problem hiding this comment.
Good find, should be otherwise
villelaitila
approved these changes
Nov 1, 2024
src/sgraph/selementassociation.py
Outdated
| return {'existingOrNewAssociation': new_association, 'isNew': True} | ||
|
|
||
| def __init__(self, fr, to, deptype, depattrs=None): | ||
| #? Is it ok to update return value? The new one is the one described in the docstring |
Looking good 🎉
|
villelaitila
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typings for most of the things. Needs to be tested thoroughly because there are couple of changes I had to make, to make the type checker happy.
Some types are still WIP 😄