Fix --yes flag to properly wait for PR merge #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, using --yes would skip waiting for PR merge entirely, causing the tag to be created on the wrong commit (before the version bump was merged). This was the root cause of v1.2.0 being tagged incorrectly. Changes: - Add polling mechanism using gh CLI to check PR merge status - Require gh CLI when using --yes (needed to verify merge) - Poll every 10 seconds with 60 minute timeout - Detect if PR is closed without merging and error appropriately - Use correct gh CLI field (state=="MERGED") instead of non-existent "merged" field 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Looking good 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--yesflag would skip waiting for PR merge, causing tags to be created on the wrong commitghCLI to automatically detect when PR is mergedChanges
jsonandtimeimports for polling functionalitywait_for_pr_merge()to acceptbranch_nameparameter_poll_for_pr_merge()helper that:gh pr viewevery 10 secondsstate == "MERGED")ghCLI when using--yesflag (needed to verify merge status)Test plan
mergedvsstatefield issue)python3 scripts/release.py --bump patch --dry-runto verify script still works--yesflag with actual release to verify polling works🤖 Generated with Claude Code