Skip to content

parts.rb: Use a mutable string #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ioquatix merged 2 commits into from
Aug 12, 2021
+3 −3
Merged

parts.rb: Use a mutable string #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a551e5
parts.rb: Use a mutable string
olleolleolle Aug 11, 2021
76f9034
parts.rb: use String.new for mutable strings
olleolleolle Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/multipart/post/parts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def length
# @param value [String]
# @param headers [Hash] Content-Type is used, if present.
def build_part(boundary, name, value, headers = {})
part = ''
part = String.new
part << "--#{boundary}\r\n"
part << "Content-ID: #{headers["Content-ID"]}\r\n" if headers["Content-ID"]
part << "Content-Disposition: form-data; name=\"#{name.to_s}\"\r\n"
Expand Down Expand Up @@ -93,7 +93,7 @@ def build_head(boundary, name, filename, type, content_len, opts = {})
trans_encoding = opts.delete("Content-Transfer-Encoding") || "binary"
content_disposition = opts.delete("Content-Disposition") || "form-data"

part = ''
part = String.new
part << "--#{boundary}\r\n"
part << "Content-Disposition: #{content_disposition}; name=\"#{name.to_s}\"; filename=\"#{filename}\"\r\n"
part << "Content-Length: #{content_len}\r\n"
Expand Down Expand Up @@ -122,7 +122,7 @@ class EpiloguePart
include Part

def initialize(boundary)
@part = "--#{boundary}--\r\n"
@part = String.new("--#{boundary}--\r\n")
@io = StringIO.new(@part)
end
end
Expand Down