Skip to content

Conversation

@cmoulliard
Copy link
Member

…'t match a location code of the language server. Fix issue #85

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
@cmoulliard cmoulliard requested a review from aureamunoz November 3, 2025 14:18
Copy link
Contributor

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are throwing an error, could we have a test checking it?

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
@cmoulliard
Copy link
Member Author

If you are throwing an error, could we have a test checking it?

This is an integration test in this case as it implies that from the when/condition, we parse the string using antlr parser to get a Query and next verify it there is a mapping from symbol to search = dependency to the language server list of the locations supported which is happening here within the code

    public List<SymbolInformation> executeQueryCommand(Config config, Rule rule, Query q) {
        String location = getLocationCode(q.symbol()); // We got a value = 0 when there is no concordance

As the module integration-tests or tests don't yet exist, I suggest to defer such a development in a next iteration and PR
WDYT ? @aureamunoz

Copy link
Contributor

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@cmoulliard cmoulliard merged commit 1c7c4fe into main Nov 3, 2025
5 checks passed
@cmoulliard cmoulliard deleted the issue-85-unknown-location-code branch December 8, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants