Skip to content

Missing function this.quantity() and a few other things #4

@diamondarts

Description

@diamondarts

Hello,

thanks for sharing your solution!

Here are a few things I stumbled upon:

  • The last commit still lists lodash as dependency although apparently you have removed all usage of _. from the code
  • this.quantity(...) leads to an undefined is not a function type error
  • $broadcast('ngCart:itemAdded', newItem) - newItem may not be initialized at this point
  • <summary> seems to be an unfortunate choice for a directive, as there is already an HTML element of the same name

Best regards,
Björn

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions