URLs should open in system browser #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swyxio
reviewed
Aug 25, 2023
Comment on lines
+203
to
+208
| contents.setWindowOpenHandler(({ url }) => { | ||
| setImmediate(() => { | ||
| shell.openExternal(url); | ||
| }) | ||
| return {action: 'deny'}; | ||
| }) |
Contributor
There was a problem hiding this comment.
i'm a little concerned about how this will act for SSO signin, but will just try this anyway! thanks for PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request all about?
Enable Godmode to open URLs in users' default browsers. Check issue: #149.
Why is the pull request important?
Instead of overriding the electron window every time a link is clicked, Godmode can now open one or multiple links in users' default browsers.
How is it achieved?
I enabled Godmode to open any link in the users' default browsers by adding an app listener to the contents of Godmode.
Demonstration (Gif)