New user, some suggestions

[timendum]

Hi,
I'm trying this right now and it's very nice.

I have a few suggestions:

• This log should be a debug, it's not a warning, or at least I would like not to see it when the run is OK level=WARN source=rss2email/processor/processor.go:282 msg="remote feed unchanged, skipping"
• The same for sleeping
• The first run fails because the ~/.rss2email folder does not exists, why not create it automatically?
• The first run after adding a new feed is always dumb, because it sends all previous items, can you add an option to immediately mark as seen items only for the new feed? I've contribuied the same in rss2email: /Add fetch option to add command rss2email/rss2email#182
• python sends "List-ID" email header, which is useful for filtering mails in Gmail, can this be added here?

Let me know if I should open split issues or if I can contribuite in any way, I'm very new to Golang, but I can still try if something is easy and agreed on.

[skx]

Thanks for the comments. I'll try to give a quick response just now.

This log should be a debug, it's not a warning, or at least I would like not to see it when the run is OK level=WARN source=rss2email/processor/processor.go:282 msg="remote feed unchanged, skipping"

That's true. I will adjust that, and the sleep you reference.

The first run fails because the ~/.rss2email folder does not exists, why not create it automatically?

On the one hand, yes. On the other hand if the configuration directory existed by there was no feed-list then I think the same thing would happen.

I think pretending a missing-directory, or missing file, meant "all okay" is a little misleading and non-obvious.

However I'd not object if you wanted to open a new issue and say "Make it show something explicit about missing configuration directory/file".

The first run after adding a new feed is always dumb, because it sends all previous items, can you add an option to immediately mark as seen items only for the new feed?

That is already somewhat documented in the README.md file:

When you add a new feed all the items contained within that feed will initially 
be unseen/new, and this means you'll receive a flood of emails if you were to ru
n:

     $ rss2email add https://blog.steve.fi/index.rss
     $ rss2email cron user@domain.com

To avoid this you can use the `-send=false` flag, which will merely
record each item as having been seen, rather than sending you emails:

     $ rss2email add https://blog.steve.fi/index.rss
     $ rss2email cron -send=false user@domain.com

I'm not sure if there's a good alternative. I think updating the "add" subcommand to also fetch and mark everything as read feels wrong. Logically "add" is just "add to feed list", not "fetch and process". And what happens if you were to run an add and an unrealted feed had new items? At the point you run rss2email add .. you don't know what email address to even notify.

So you might say "add example.com/feed" would only fetch and mark-read the new feed. But it feels a little wrong to me regardless.

python sends "List-ID" email header, which is useful for filtering mails in Gmail, can this be added here?

If you look at the default email template you'll see there are headers added:

• X-RSS-Link: {{.Link}}
• X-RSS-Feed: {{.Feed}}

Which are designed to serve that purpose. In the README.md file you can see how to customize the template, either globally or on a per-feed basis too. But if you have a concrete header & value suggestion to make I'd be open to updating the default.

Thanks again for the feedback :)

[timendum]

On the one hand, yes. On the other hand if the configuration directory existed by there was no feed-list then I think the same thing would happen.

But the same appends when I "add" a new feed, rss2mail complains about the missing folder.

I'm not sure if there's a good alternative. I think updating the "add" subcommand to also fetch and mark everything as read feels wrong. Logically "add" is just "add to feed list", not "fetch and process". And what happens if you were to run an add and an unrealted feed had new items? At the point you run rss2email add .. you don't know what email address to even notify.

My proposal is to fetch and mark as read only items in the added url. So I i perform add --fetch <url> rss2mail add it to the feed list, fetch <url> and mark all URLs in this feed as read, without sending any mail.

The idea is the possibility to add a feed without getting dozens of mail for previous content. In my case, I'm migrating from rss2mail python and I've already got these mails.