Skip to content

Conversation

@math2001
Copy link

Hi!

I added a simple feature: when you extract a package, it opens the containing folder for you.

I added a setting to enable it (default to false to keep the default behavior), and I updated the menu: it uses the edit_settings command (open a new window splited in half with the default on the left and the users on the right). I also removed the open readme, to make people use Readme​Please (guess you didn't know it, try it, it's really cool)

Hope you'll accept it, but if there's any problem, just tell me, I'll try to fix them.

Thanks for your plugin anyway. 👍 😄

Matt

"caption": "Settings – User"
}
]
"command": "edit_settings",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a ST3 specific command? Thusfar, the plugin is compatible as is with both ST2 and ST3. I think everything is pretty well established for ST2 now, so I don't have any problem branching it. It's just something I'd need to do for package control to make sure everything still works for both.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunatly, this a ST3 command only, i've just checked. I don't really understand, do you want to create a branch for ST2 and ST3, or not?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll create a separate branch for ST2. My point was just that what I have is stable (from an ST2 perspective), so not expecting many bugs to come up with it. :) All the plugins I have right now are compatible with both ST2 and ST3, so I'll just need to read through the package control docs on how to do a version for each.

Copy link
Author

@math2001 math2001 Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found something else: we could create a polyfill for it, or just simply propose ST2 user to download the plugin that enables this plugin. It's in here: Packages/Default/settings.py.

So, you could in the readme do something like this:

For sublime text 2 users

  1. Copy this plugin's code - EDIT: This plugin is not compatible with ST2, so I've created a new one here: a gist settings.py It should do the same thing.
  2. Create a file in your sublime user (Preferences -> Browse Packages, and find User) directory, and call it settings.py
  3. Paste the code you've just copied in this file

Matt

"args": {"file": "${packages}/PackageResourceViewer/README.md"},
"caption": "README"
},
{ "caption": "-" },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to leave these here, but thanks for pointing out ReadmePlease to me!

@skuroda
Copy link
Owner

skuroda commented Dec 1, 2016

Hi Mathieu, I hadn't forgotten about this. I've submitted a PR to package control so I can support a version for ST2 and ST3. Once that's through I can merge this in.

@math2001
Copy link
Author

math2001 commented Dec 1, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants