Proposal to add URL -> android.net.Uri conversion helper#47
Open
ky-is wants to merge 1 commit intoskiptools:mainfrom
Open
Proposal to add URL -> android.net.Uri conversion helper#47ky-is wants to merge 1 commit intoskiptools:mainfrom
ky-is wants to merge 1 commit intoskiptools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to propose adding a public method to
URLthat converts to aandroid.net.Uri. The platformValue isjava.net.URI, but many APIs require the former type.toPathis analogous for converting tojava.nio.file.Path.This conversion is done slightly inconsistently in skip frameworks (see https://github.com/search?q=org%3Askiptools%20Uri.parse&type=code), so it could be good to standardize. I also use this in my app to pass a URL to Android-specific file APIs, so I think it would be helpful to have available publicly.
swift test