Standardize stdin reading and args validation #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 16, 2025 01:29
- Change all formatters to use cmd.InOrStdin() instead of os.Stdin * jsonfmt, tomlfmt, xmlfmt, cssfmt, cssmin * csv2md, tsv2md - Simplify complex input detection in urls, base64, count * Remove file path auto-detection * Keep simple pattern: args[0] for string OR stdin for piped input * Aligns with Unix philosophy and improves testability Benefits: - All commands now testable with cmd.SetIn() - Consistent API across all commands - Simpler, more maintainable code - Better follows Unix conventions Note: base64_cli_test.go needs updates to use stdin instead of file args
- Rewrite all file path tests to use stdin instead - Files are read and piped via stdin: cat file | devtui base64 - Maintains test coverage while aligning with new standardized pattern - All tests pass successfully
Created internal/input package with 3 helper functions: - ReadFromStdin: For formatters that only accept stdin - ReadFromArgsOrStdin: For commands accepting args or stdin (returns string) - ReadBytesFromArgsOrStdin: Same as above but returns bytes Benefits: - DRY principle: Eliminates duplicate input reading logic - Testability: Helpers are fully tested (13 test cases) - Consistency: All commands use same pattern - Maintainability: Changes to input logic in one place - Validation: Added Args: cobra.MaximumNArgs(1) to prevent multiple args Refactored commands: - json2toon, jsonfmt, tomlfmt, xmlfmt (stdin only) - base64, urls, count (args or stdin) All tests pass, zero linting issues.
skatkov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.