Add TypeScript definition#11
Merged
sindresorhus merged 1 commit intosindresorhus:masterfrom Apr 22, 2019
BendingBender:typescript-defs
Merged
Add TypeScript definition#11sindresorhus merged 1 commit intosindresorhus:masterfrom BendingBender:typescript-defs
sindresorhus merged 1 commit intosindresorhus:masterfrom
BendingBender:typescript-defs
Conversation
| // OMG, YES! | ||
| ``` | ||
| */ | ||
| declare function negativeArray<T extends readonly unknown[]>(array: T): T; |
Owner
There was a problem hiding this comment.
Does this cause the returned array to be readonly too? If yes, I'm not sure it's worth it, as we decided it's not worth returning readonly array as it's inconvenient for the user.
Contributor
Author
There was a problem hiding this comment.
No, this is not what's happening here. This is just a base type, this means that if the incoming type is an ReadonlyArray then the result will also be one, if the incoming type is a plain Array then the resulting type will be an Array.
This is even covered by the tests.
Owner
There was a problem hiding this comment.
Ah, sorry, I should have looked at the tests... But thanks for the explanation. I was not sure how the readonly keyword worked with the base type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.